Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

바텀내비게이션 더보기 탭 red dot 삭제 #248

Merged
merged 3 commits into from
Feb 3, 2024
Merged

바텀내비게이션 더보기 탭 red dot 삭제 #248

merged 3 commits into from
Feb 3, 2024

Conversation

eastshine2741
Copy link
Collaborator

@eastshine2741 eastshine2741 commented Feb 1, 2024 •
edited
Loading

  • 알림 아이콘이 TimetablePage로 넘어갔는데 uncheckedNotification reddot이 바텀내비게이션 더보기탭에 남아있었다....
  • 다른 이야기인데, LecturesOfTablePage에 fillMaxSize가 없어서 내비게이션이 어색한 점 발견하여 수정

@eastshine2741 eastshine2741 requested a review from a team as a code owner February 1, 2024 16:45
@eastshine2741 eastshine2741 changed the title Eastshine2741/fix more tab reddot 더보기 탭 red dot 삭제 Feb 1, 2024
@eastshine2741 eastshine2741 changed the title 더보기 탭 red dot 삭제 바텀내비게이션 더보기 탭 red dot 삭제 Feb 1, 2024
@eastshine2741 eastshine2741 merged commit adc69a4 into develop Feb 3, 2024
3 checks passed
@eastshine2741 eastshine2741 deleted the eastshine2741/fix-more-tab-reddot branch February 3, 2024 03:06
@eastshine2741 eastshine2741 mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuTaK97 JuTaK97 JuTaK97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastshine2741 @JuTaK97